Add __getattr__ typing hints to Record class#169
Merged
Conversation
This improves support for type checkers when using Records.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
==========================================
- Coverage 82.84% 82.82% -0.02%
==========================================
Files 34 34
Lines 3574 3576 +2
==========================================
+ Hits 2961 2962 +1
- Misses 613 614 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds a type hint for the getattr method in the Record class to improve support for type checkers.
- Adds an getattr signature under a TYPE_CHECKING block to avoid runtime overhead while improving static analysis.
Comments suppressed due to low confidence (1)
flow/record/base.py:189
- Consider adding a comment clarifying that getattr is defined within a TYPE_CHECKING block solely for static analysis, and it does not impact runtime behavior.
def __getattr__(self, name: str) -> Any: ...
Schamper
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves support for type checkers when using Records.